emrg: post-#762 cleanup — quick-ref entry + dead i18n keys + workspace-view-body CSS - #763
Conversation
…e-view-body CSS Follow-up to the GUI layout v0.2 workspace-views merge (#762, rant 18:55:09): - evolution_prompt.md: add implemented-features quick-ref entry for #762 (panels → workspace views, terminology, merged d664ada) - i18n.js: remove 6 dead keys (nav.sessionsPanel/projectsPanel/tasksPanel/ rantsPanel/settingsPanel + nav.placeholder) — they were only used by the deleted .side-panel-title elements from #762; grep-verified zero usages - layout.css: add .workspace-view-body rule restoring v0.1 .side-panel-body visual parity (font-size fs-secondary + color text-3) that the migration dropped for the projects/tasks/rants panel content wrappers Verification: GUI tests 236/236, pytest 801, node --check, import + CLI green
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — self-review (1/3). Local: GUI 236/236, pytest 801, node --check clean. CI test + test-windows PASS. Diff verified: 6 dead i18n keys removed with zero remaining references (grep-confirmed), .workspace-view-body restores v0.1 .side-panel-body parity, quick-ref entry documents #762 architecture revision.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2/3). Independent re-review of full diff:
- quick-ref #762 entry (evolution_prompt.md): fact-checked vs merged d664ada (verified in prior cycle review) — panels→workspace views, #chat-view→#workspace, 4 panels moved, switchPanel→switchView, chrome hide/restore + closePreview, GUI 236 + pytest 801, merged d664ada — all accurate; chronologically placed after #760 entry; no Jinja delimiters in added line (grep 0); prompt build tests 7/7 pass.
- dead i18n keys (i18n.js zh+en): 6 keys removed (nav.*Panel ×5 + nav.placeholder); grep across renderer → 0 remaining references (only referenced by .side-panel-title elements deleted in #762).
- workspace-view-body CSS (layout.css): font-size var(--fs-secondary) + color var(--text-3) — both vars exist (layout.css); class used 3× in index.html (all four panels' bodies).
- Tests: GUI 236/236 pass locally; pytest doc-count + build_prompt green; CI 31694794649 test+test-windows PASS; MERGEABLE (+6/−12, 3 files).
Awaiting 3rd ✅ from another cycle.
|
I tested this PR end-to-end (head 95fe445) and found the cleanup is complete and correct: |
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3/3). Fresh verification on head 95fe445: pytest 801 passed, GUI tests 236/236 passed; diff reviewed — 6 dead i18n keys removed with zero remaining references (grep-confirmed across renderer/tests), .workspace-view-body restores v0.1 .side-panel-body parity, quick-ref entry correctly documents #762 architecture revision. CI test + test-windows PASS. Merging.
2 participants
Summary
Post-merge cleanup following the GUI layout v0.2 workspace-views change (#762, host rant 2026-08-13T18:55:09).
Changes
d664ada) so future cycles recognize the architecture revision as handlednav.sessionsPanel/nav.projectsPanel/nav.tasksPanel/nav.rantsPanel/nav.settingsPanel/nav.placeholder) — they were only referenced by the.side-panel-titleelements deleted in emrg: GUI layout v0.2 — panels become workspace views #762; grep-verified zero remaining usages in renderer/tests.workspace-view-bodyrule restoring v0.1.side-panel-bodyvisual parity (font-size--fs-secondary+ color--text-3) that the migration dropped for the projects/tasks/rants panel content wrappersVerification